[PATCH 3 of 3] Scgi: removed error if there is no Status header

Maxim Dounin mdounin at mdounin.ru
Mon Dec 12 19:19:01 UTC 2011


# HG changeset patch
# User Maxim Dounin <mdounin at mdounin.ru>
# Date 1323713244 -10800
# Node ID b412333cff4fd53de8dbf4a3bedbc86c201fdece
# Parent  055c3b0ac991ebc1930681c665a5c1e5d0b78f8c
Scgi: removed error if there is no Status header.

The SCGI specification doesn't specify format of the response, and assuming
CGI specs should be used there is no reason to complain.  RFC 3875
explicitly states that "A Status header field is optional, and status
200 'OK' is assumed if it is omitted".

diff --git a/src/http/modules/ngx_http_scgi_module.c b/src/http/modules/ngx_http_scgi_module.c
--- a/src/http/modules/ngx_http_scgi_module.c
+++ b/src/http/modules/ngx_http_scgi_module.c
@@ -982,9 +982,6 @@ ngx_http_scgi_process_header(ngx_http_re
                             "302 Moved Temporarily");
 
             } else {
-                ngx_log_error(NGX_LOG_ERR, r->connection->log, 0,
-                              "upstream sent neither valid HTTP/1.0 header "
-                              "nor \"Status\" header line");
                 u->headers_in.status_n = 200;
                 ngx_str_set(&u->headers_in.status_line, "200 OK");
             }



More information about the nginx-devel mailing list