[PATCH] Fix a memory invalid read issue in ngx_http_gzip_ok

Maxim Dounin mdounin at mdounin.ru
Thu Dec 22 13:21:28 UTC 2011


On Thu, Dec 22, 2011 at 08:18:41PM +0800, agentzh wrote:

> On Thu, Dec 22, 2011 at 5:00 PM, Maxim Dounin <mdounin at mdounin.ru> wrote:
> > I suppose the problem is instead in your code which (incorrectly)
> > adds headers to r->headers_in.
> >
> I do strongly suggest we *should* support manipulating request
> headers, it's often desired by many people in real world settings :)

As I already said more than once, I don't think we should.  If 
it's needed - it means something else needs fixing.  We do support 
arbitrary modification of headers passed to upstream servers, and 
this should be enough.

But, actually, nobody stops you from adding headers correctly, 
i.e. null-terminated.

Maxim Dounin

More information about the nginx-devel mailing list