[Patch] Make resolver port configurable
usirsiwal at verivue.com
Tue Feb 15 00:27:30 MSK 2011
I must say I am new to Nginx. My apologies for not following existing style. I will rework the patch following existing style.
I did look at ngx_parse_url. But that accepts a lot more things which are not directly applicable to resolver configuration (e.g. "/", args, etc.). If I just use ngx_parse_url, the function will try to parse input as normal URL.
Also it looks like at present nginx only accepts IPv4 addresses. The ngx_parse_url will accept V6 addresses as well. How do you suggest I use the ngx_parse_url()?
> -----Original Message-----
> From: Maxim Dounin [mailto:mdounin at mdounin.ru]
> Sent: Monday, February 14, 2011 4:15 PM
> To: nginx-devel at nginx.org
> Subject: Re: [Patch] Make resolver port configurable
> On Mon, Feb 14, 2011 at 03:53:47PM -0500, Sirsiwal, Umesh wrote:
> > Thanks for the feedback. Here is update patch. This does not
> > need a second parameter. Just allows host:port based
> > configuration.
> Just my 2 cents:
> 1. You may want to follow style to make all of us happy.
> 2. Using ngx_parse_url() instead of reinventing the wheel is a
> good idea.
> Maxim Dounin
> nginx-devel mailing list
> nginx-devel at nginx.org
More information about the nginx-devel