[PATCH] Allow binary upgrades in Solaris zones

doug at hcsw.org doug at hcsw.org
Thu Jan 6 19:22:33 MSK 2011

Hi Piotr,

I tested your patch and it does in fact work for me (thank you).

On Wed, Jan 05, 2011 at 09:14:48PM +0100 or thereabouts, Piotr Sikora wrote:
> 1) You are introducing unnecessary function call for all users, this new 
> code-path should be evaluated only for Solaris users.

Personally I wouldn't worry about this because it is not on a "hot path"
although your approach looks fine too.

> 2) You are assuming that nginx is running as root, which isn't always true.

True. This was necessary because non-root processes can never send signals to
init so the test is meaningless if you are not root.

My only issue with your approach of using getzoneid() is that I'm afraid it may
break compilation on Solaris versions prior to 10 although I have no way to test

Doug Hoyte

More information about the nginx-devel mailing list