[patch] log request only when they reached a size

Maxim Dounin mdounin at mdounin.ru
Fri Nov 25 12:26:26 UTC 2011


On Thu, Nov 24, 2011 at 05:26:36PM +0100, KARASZI Istvan wrote:

> Dear list!
> I think I sent my previous mail to a bad location, so I'm 
> resending it from nginx list to nginx-devel.
> I would like to send a patch for http_log_module which I made 
> for version nginx-1.0.10.
> My company is in adserving business and it is important for us 
> to log the big requests with the access_log feature. But we were 
> unable to do that with nginx, because logging all the requests 
> would produce too much I/O load on our servers.
> So I made a patch for http_log_module to accept a `size` 
> parameter which is optional (the last parameter after the 
> `buffer`). If this `size` is provided nginx logs only the big 
> enough requests with access_log (checks for `body_bytes_sent`).
> I hope you find it useful and you will include this in the 
> upstream.

The patch looks mostly fine, though I don't think it's good idea 
to include it as is.  We probably need more generic filtering 
machinery, something like

    access_log ... if=<condition>;

Maxim Dounin

More information about the nginx-devel mailing list