[PATCH] Fix logging keepalive related variables bug

Maxim Dounin mdounin at mdounin.ru
Fri Feb 24 04:33:34 UTC 2012


On Thu, Feb 23, 2012 at 03:21:05PM +0800, Joshua Zhu wrote:

> Hi,
> On Mon, Feb 13, 2012 at 3:08 PM, Joshua Zhu <zhuzhaoyuan at gmail.com> wrote:
> > Hi,
> >
> > A bug was introduced in revision 3181 that r->keepalive was set to 0
> > before calling ngx_http_log_reques(), so the $sent_http_connection and
> > $sent_http_keep_alive variables will not work anymore.
> Could someone please review this patch?

It's flagged in my mailbox.  There is nothing wrong with the 
patch, but I tend to think that original r3181 is wrong and should 
be just reverted (or redone properly if it tries to address some 
valid problem).  I've tried to ask Igor about it but he doesn't 
remember details, so it waits for detailed invesigation.

Maxim Dounin

More information about the nginx-devel mailing list