[PATCH] Fix logging keepalive related variables bug
mdounin at mdounin.ru
Thu Jun 21 17:08:03 UTC 2012
On Thu, Jun 21, 2012 at 10:55:49AM +0800, agentzh wrote:
> On Fri, Feb 24, 2012 at 12:33 PM, Maxim Dounin <mdounin at mdounin.ru> wrote:
> > On Thu, Feb 23, 2012 at 03:21:05PM +0800, Joshua Zhu wrote:
> >> On Mon, Feb 13, 2012 at 3:08 PM, Joshua Zhu <zhuzhaoyuan at gmail.com> wrote:
> >> > Hi,
> >> >
> >> > A bug was introduced in revision 3181 that r->keepalive was set to 0
> >> > before calling ngx_http_log_reques(), so the $sent_http_connection and
> >> > $sent_http_keep_alive variables will not work anymore.
> >> Could someone please review this patch?
> > It's flagged in my mailbox. There is nothing wrong with the
> > patch, but I tend to think that original r3181 is wrong and should
> > be just reverted (or redone properly if it tries to address some
> > valid problem). I've tried to ask Igor about it but he doesn't
> > remember details, so it waits for detailed invesigation.
> Any progress on this issue? It seems that it still exists in at least
> nginx 1.0.15 and 1.2.1 :)
No progress yet, ENOTIME.
More information about the nginx-devel