[PATCH] Random peer selection for implicit upstream defined by proxy_pass

Maxim Dounin mdounin at mdounin.ru
Sat Sep 29 07:24:38 UTC 2012


On Fri, Sep 28, 2012 at 01:08:30PM -0700, Anton Jouline wrote:

> hi Maxim,
> yes, attribution in CHANGES.ru would be great, thanks!
> In Russian, my name is spelled as: Антон Жулин

Yep, that's what I supposed but wasn't sure.   Thanks for 
clarification.  :)

> One comment on changeset 4872:
> On line #1385, wouldn't you want to call ngx_resolver_rotate()
> instead of ngx_resolver_dup() ? To cover the case of the name
> not being cached at all for some odd reason - like, if TTL is set
> to 0 seconds. Or, if TTL is really small, which would also skew
> the distribution to use the 1st addr a lot more than others.

I think in this case it's up to DNS server to do proper 
rotation/randomization, and if it doesn't do that - it's probably 
for reason.

Maxim Dounin

More information about the nginx-devel mailing list