Dead code in accept

[SplitIce]

I agree, I view dead code at run-time as a liability. Something that can go
wrong. At compile time, you know everything about the sytem, the config
script makes assumptions and the binaries shouldnt work if moved to a
different OS etc anyway.

I am not a nginx developer just a C++ developer.


On Mon, Aug 5, 2013 at 4:28 PM, Serguei I. Ivantsov <
manowar at gsc-game.kiev.ua> wrote:

> I think it is not a matter for trade - "dead code" - is bad programming
> technique. And it should be eliminated in a fast web server.
> Of course, general impact on overall performance is not significant, but
> on function level it will be much noticeable. I can make a perf profiling
> test to get exact counters.
>
> > Hello!
> >
> > On Mon, Aug 05, 2013 at 12:15:04AM +0300, Serguei I. Ivantsov wrote:
> >
> > [...]
> >
> >> A little test with high volume of simple requests shows 0.5% overall
> >> speed
> >> improvement.
> >
> > Are you sure the numbers are significant?  Doing a ministat(1)
> > analysis or similar is a good idea.
> >
> > http://www.freebsd.org/cgi/man.cgi?query=ministat&sektion=1
> >
> > --
> > Maxim Dounin
> > http://nginx.org/en/donation.html
> >
>
>
> _______________________________________________
> nginx-devel mailing list
> nginx-devel at nginx.org
> http://mailman.nginx.org/mailman/listinfo/nginx-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.nginx.org/pipermail/nginx-devel/attachments/20130805/4948a195/attachment-0001.html>