[nginx] Fixed ngx_http_test_reading() to finalize request properly.

Maxim Dounin mdounin at mdounin.ru
Thu Jul 25 11:58:42 UTC 2013


details:   http://hg.nginx.org/nginx/rev/aadfadd5af2b
branches:  
changeset: 5289:aadfadd5af2b
user:      Maxim Dounin <mdounin at mdounin.ru>
date:      Fri Jun 14 20:56:07 2013 +0400
description:
Fixed ngx_http_test_reading() to finalize request properly.

Previous code called ngx_http_finalize_request() with rc = 0.  This is
ok if a response status was already set, but resulted in "000" being
logged if it wasn't.  In particular this happened with limit_req
if a connection was prematurely closed during limit_req delay.

diffstat:

 src/http/ngx_http_request.c |  2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diffs (12 lines):

diff --git a/src/http/ngx_http_request.c b/src/http/ngx_http_request.c
--- a/src/http/ngx_http_request.c
+++ b/src/http/ngx_http_request.c
@@ -2733,7 +2733,7 @@ closed:
     ngx_log_error(NGX_LOG_INFO, c->log, err,
                   "client prematurely closed connection");
 
-    ngx_http_finalize_request(r, 0);
+    ngx_http_finalize_request(r, NGX_HTTP_CLIENT_CLOSED_REQUEST);
 }
 
 



More information about the nginx-devel mailing list