[PATCH] ngx_mail_ssl_module / ecdh_curve

[Maxim Dounin]

Hello!

On Mon, May 20, 2013 at 06:40:14PM +0200, Filipe Da Silva wrote:

> Hello ,
> 
> Please find attach a two lines patch about ecdh_curve setting in
> mail_ssl_module.
> 
> This setting is not applied, although it is declared and parsed from
> nginx.conf file
> 
> I see this lack in 1.2.0 version too.

Nice catch, thanks.

> 
> Rgds,
> Filipe DA SILVA

> # HG changeset patch
> # User fds <fdasilvayy at gmail.com>

Could you please use a proper name here?  Just "fds" looks wierd.

> # Date 1368197625 -7200
> # Node ID f6c3e219648f47eaa65ab43a8189af31f7babc69
> # Parent  7ffe7f3be4045dbc7478248370b473271660e473
> Missing call to ngx_ssl_ecdh_curve in mail_ssl_module

Please use trailing dot and "Mail:" prefix for mail-related 
changes.

That is, I would like to see something like this here:

Mail: missing ngx_ssl_ecdh_curve() call.

> 
> diff -r 7ffe7f3be404 -r f6c3e219648f src/mail/ngx_mail_ssl_module.c
> --- a/src/mail/ngx_mail_ssl_module.c	Thu May 09 10:54:28 2013 +0200
> +++ b/src/mail/ngx_mail_ssl_module.c	Fri May 10 16:53:45 2013 +0200
> @@ -308,6 +308,10 @@
>          return NGX_CONF_ERROR;
>      }
>  
> +    if (ngx_ssl_ecdh_curve(cf, &conf->ssl, &conf->ecdh_curve) != NGX_OK) {
> +        return NGX_CONF_ERROR;
> +    }
> +
>      ngx_conf_merge_value(conf->builtin_session_cache,
>                           prev->builtin_session_cache, NGX_SSL_NONE_SCACHE);
>  

-- 
Maxim Dounin
http://nginx.org/en/donation.html