[PATCH] Core: stop trying to get TCP_DEFER_ACCEPT from unix sockets.

Maxim Dounin mdounin at mdounin.ru
Fri Oct 25 18:16:28 UTC 2013


Hello!

On Thu, Oct 24, 2013 at 02:22:02PM -0700, Piotr Sikora wrote:

> # HG changeset patch
> # User Piotr Sikora <piotr at cloudflare.com>
> # Date 1382649516 25200
> #      Thu Oct 24 14:18:36 2013 -0700
> # Node ID c677648001a2efc383e97229251a5f1df8407122
> # Parent  e6a1623f87bc96d5ec62b6d77356aa47dbc60756
> Core: stop trying to get TCP_DEFER_ACCEPT from unix sockets.
> 
> Signed-off-by: Piotr Sikora <piotr at cloudflare.com>
> 
> diff -r e6a1623f87bc -r c677648001a2 src/core/ngx_connection.c
> --- a/src/core/ngx_connection.c Mon Oct 21 18:20:32 2013 +0800
> +++ b/src/core/ngx_connection.c Thu Oct 24 14:18:36 2013 -0700
> @@ -242,6 +242,10 @@ ngx_set_inherited_sockets(ngx_cycle_t *c
> 
>  #if (NGX_HAVE_DEFERRED_ACCEPT && defined TCP_DEFER_ACCEPT)
> 
> +        if (ls[i].sockaddr->sa_family == AF_UNIX) {
> +            continue;
> +        }
> +
>          timeout = 0;
>          olen = sizeof(int);

Any specific reason to?  It doesn't seems to fail / produce any 
problems, and may even start working eventually.

-- 
Maxim Dounin
http://nginx.org/en/donation.html



More information about the nginx-devel mailing list