[nginx] Adjusted default value of types_hash_bucket_size (ticket...

Maxim Dounin mdounin at mdounin.ru
Tue Apr 1 13:50:13 UTC 2014

details:   http://hg.nginx.org/nginx/rev/5a65b9d8bc2b
changeset: 5637:5a65b9d8bc2b
user:      Maxim Dounin <mdounin at mdounin.ru>
date:      Mon Mar 31 22:47:42 2014 +0400
Adjusted default value of types_hash_bucket_size (ticket #352).

The ngx_cacheline_size may be too low on some platforms, resulting
in unexpected hash build problems (as no collisions are tolerated due
to low bucket_size, and max_size isn't big enough to build a hash without
collisions).  These problems aren't fatal anymore but nevertheless
need to be addressed.


 src/http/ngx_http_core_module.c |  3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diffs (13 lines):

diff --git a/src/http/ngx_http_core_module.c b/src/http/ngx_http_core_module.c
--- a/src/http/ngx_http_core_module.c
+++ b/src/http/ngx_http_core_module.c
@@ -3710,8 +3710,7 @@ ngx_http_core_merge_loc_conf(ngx_conf_t 
                               prev->types_hash_max_size, 1024);
-                              prev->types_hash_bucket_size,
-                              ngx_cacheline_size);
+                              prev->types_hash_bucket_size, 64);
     conf->types_hash_bucket_size = ngx_align(conf->types_hash_bucket_size,

More information about the nginx-devel mailing list