[PATCH] Cache: check if ETag and Vary didn't change before updating header

Maxim Dounin mdounin at mdounin.ru
Tue Dec 23 01:16:25 UTC 2014


On Mon, Dec 22, 2014 at 02:58:43PM -0800, Piotr Sikora wrote:

> Hey Maxim,
> > The check in question is mostly a safeguard to ensure that
> > ngx_file_uniq() check above did it's work properly.
> I'm aware of that.
> > Any specific reason to assume it needs to be extended?
> It just seems inconsistent to check only some of the fields that
> aren't supposed to change (i.e. version, last modified, etc.), but not
> the others (i.e. etag and vary).

Ok, understood.  I don't think this check needs to be extended - as 
of now it checks basic fixed-width fields, and I think these 
checks should be sufficient.

Maxim Dounin

More information about the nginx-devel mailing list