[PATCH] Use ngx_socket_errno where appropriate.

Maxim Dounin mdounin at mdounin.ru
Wed Feb 5 15:20:27 UTC 2014


Hello!

On Wed, Feb 05, 2014 at 05:10:57PM +0400, Ruslan Ermilov wrote:

> On Mon, Feb 03, 2014 at 02:22:39PM -0800, Piotr Sikora wrote:
> > Hey,
> > 
> > > Note that I still agree with Ruslan's comments to your patch, use
> > > of ngx_socket_errno to check errors from ioctl() / fcntl() in
> > > unix-specific code looks unneeded.  And in case of eventfd - it
> > > looks certainly wrong, as eventfd isn't a socket.
> > >
> > > I would rather drop most of the src/os/unix changes, probably with
> > > the exception of ngx_tcp_nopush() checks.
> > 
> > Done.
> 
> Your latest patch looks good to me.

Same here.  Committed, thanks.

-- 
Maxim Dounin
http://nginx.org/



More information about the nginx-devel mailing list