Patch: Refactor ngx_http_write_request_body into a filter
grrm77 at gmail.com
Wed Jul 23 19:57:41 UTC 2014
I would like to invest some time into this. Do you point out any
specific mistakes I made, or where code just doesn't look right? Or it
is just that a move to the request filters would imply some design
changes that would have to be considered more carefully?
Although I didn't like setting flush in the request body read
function, I saw that flush is set for all buffers in the proxy input
filter for example in the non-buffered logic.
2014-07-09 4:58 GMT+03:00 Maxim Dounin <mdounin at mdounin.ru>:
> On Tue, Jul 08, 2014 at 11:16:47PM +0300, grrm grrm wrote:
>> Thanks for the reply. I understand the hesitation to include new code
>> with changes more than cosmetic, but without any real benefit.
>> What if this was part of a greater initiative to implement
>> non-buffered request body processing. Would that be an acceptable
>> modification to start with? (Because that was tentatively my
> No. If you want to move writing a request body into the filter
> chain, it should be done better.
> Maxim Dounin
> nginx-devel mailing list
> nginx-devel at nginx.org
More information about the nginx-devel