Patch: Refactor ngx_http_write_request_body into a filter
mdounin at mdounin.ru
Thu Jul 24 21:00:05 UTC 2014
On Thu, Jul 24, 2014 at 11:33:24PM +0300, grrm grrm wrote:
> Hi! Thanks for the response. Quick question, I set the flush flag only
> when the request body buffer is full. Is it still a problem?
This may be ok if it's then handled and removed, and won't stay in
the resulting body buffers chain.
> 2014-07-24 23:04 GMT+03:00 Maxim Dounin <mdounin at mdounin.ru>:
> > Hello!
> > On Wed, Jul 23, 2014 at 10:57:41PM +0300, grrm grrm wrote:
> >> Hello, Maxim.
> >> I would like to invest some time into this. Do you point out any
> >> specific mistakes I made, or where code just doesn't look right? Or it
> >> is just that a move to the request filters would imply some design
> >> changes that would have to be considered more carefully?
> > In this particular patch you are trying to make a filter from the
> > ngx_http_write_request_body() function, and you are moving
> > existing save filter into it - instead of using already existing
> > save filter, and using the ngx_http_write_request_body() in it.
> >> Although I didn't like setting flush in the request body read
> >> function, I saw that flush is set for all buffers in the proxy input
> >> filter for example in the non-buffered logic.
> > Unconditionally setting the flush flag looks wrong - in
> > particular, this will cause unneeded flushes when sending large
> > bodies over SSL connections.
> > --
> > Maxim Dounin
> > http://nginx.org/
> > _______________________________________________
> > nginx-devel mailing list
> > nginx-devel at nginx.org
> > http://mailman.nginx.org/mailman/listinfo/nginx-devel
> nginx-devel mailing list
> nginx-devel at nginx.org
More information about the nginx-devel