[PATCH 2 of 2] SSL: let it build against BoringSSL

Maxim Dounin mdounin at mdounin.ru
Wed Jul 30 12:22:43 UTC 2014


Hello!

On Tue, Jul 29, 2014 at 10:32:29PM -0700, Piotr Sikora wrote:

> Hey Maxim,
> 
> > The problem is lots of added lines required to avoid calling it.
> 
> Alternatively, would you be OK with a change that adds #ifndefs around
> SSL_CTX_set_tmp_rsa_callback() in ngx_http_ssl_module and
> ngx_mail_ssl_module, but keeps ngx_ssl_rsa512_key_callback without
> guards? It's exported, so compilers won't complain about it being
> unused.

I don't really think we at all need these ifdefs.  Additionally, I 
tend to think that we don't need SSL_CTX_set_tmp_rsa_callback() in 
mail/http either, it should be hidden in openssl glue code.

-- 
Maxim Dounin
http://nginx.org/



More information about the nginx-devel mailing list