[nginx] Upstream: no need to clear r->headers_out.last_modified_...

Maxim Dounin mdounin at mdounin.ru
Wed Jun 25 22:40:08 UTC 2014


details:   http://hg.nginx.org/nginx/rev/c8bdde1c8c97
branches:  
changeset: 5730:c8bdde1c8c97
user:      Maxim Dounin <mdounin at mdounin.ru>
date:      Thu Jun 26 02:19:58 2014 +0400
description:
Upstream: no need to clear r->headers_out.last_modified_time.

Clearing of the r->headers_out.last_modified_time field if a response
isn't cacheable in ngx_http_upstream_send_response() was introduced
in 3b6afa999c2f, the commit to enable not modified filter for cacheable
responses.  It doesn't make sense though, as at this point header was
already sent, and not modified filter was already executed.  Therefore,
the line was removed to simplify code.

diffstat:

 src/http/ngx_http_upstream.c |  1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diffs (11 lines):

diff --git a/src/http/ngx_http_upstream.c b/src/http/ngx_http_upstream.c
--- a/src/http/ngx_http_upstream.c
+++ b/src/http/ngx_http_upstream.c
@@ -2500,7 +2500,6 @@ ngx_http_upstream_send_response(ngx_http
 
         } else {
             u->cacheable = 0;
-            r->headers_out.last_modified_time = -1;
         }
     }
 



More information about the nginx-devel mailing list