[PATCH] SSL support for the mail proxy module
kpariani at zimbra.com
Tue Sep 16 07:30:17 UTC 2014
Updated the diffs after addressing the first 2 issues.
Regarding the 3rd comment, you are correct. Only 1 set of ssl settings for all the mail backends with my patch. I guess this will be a limitation with the current mail proxy workflow ? Am not sure of the exact changes that will be required to address this issue completely.
Also skipped the non-trivial name related ssl directives from http proxy module as suggested by Maxim.
----- Original Message -----
From: "Filipe Da Silva" <fdasilvayy at gmail.com>
To: "nginx-devel" <nginx-devel at nginx.org>
Sent: Monday, September 15, 2014 10:48:10 PM
Subject: Re: [PATCH] SSL support for the mail proxy module
I see at least three issues in this patch:
- a mixed use of NGX_MAIL_SSL and NGX_HTTP_SSL defines
- a wrong patch format: please add this item to your .hgrc config file:
showfunc = True
- as Maxim previously explains, there a conflict with the mail proxy workflow and your changes.
Currently, the mail back-end server address ( ip+port) is dynamically returned by the auth script ( called by HTTP ).
With your patch, there is only one set of ssl settings for all the mail back-ends, if I'm not wrong ?
HTH and regards,
2014-09-14 1:14 GMT+02:00 Kunal Pariani <kpariani at zimbra.com>:
> # HG changeset patch
> # User Kunal Pariani <kpariani at zimbra.com>
> # Date 1410649455 18000
> # Sat Sep 13 18:04:15 2014 -0500
> # Node ID 5c2524403ab7c870b1fa7294f935d3292f25fd1d
> # Parent e3016ee8dba396614f28a3644996b8cc6de8f9e3
> SSL support for the mail proxy module
> diff -r e3016ee8dba3 -r 5c2524403ab7 src/mail/ngx_mail_proxy_module.c
> --- a/src/mail/ngx_mail_proxy_module.c Sat Sep 13 21:47:13 2014 +0400
> +++ b/src/mail/ngx_mail_proxy_module.c Sat Sep 13 18:04:15 2014 -0500
nginx-devel mailing list
nginx-devel at nginx.org
More information about the nginx-devel