[PATCH] Fix typo

XiaoBing Jiang s7v7nislands at gmail.com
Sun Sep 28 04:00:45 UTC 2014


I grep the '#if 0', find many in code.

why this don't using '#if 0'?  I feel using '#if (NGX_THREADS0)' is
more confused.

On Sat, Sep 27, 2014 at 12:13 PM, Valentin V. Bartenev <vbart at nginx.com> wrote:
> On Saturday 27 September 2014 07:45:35 XiaoBing Jiang wrote:
>> thanks! so can we just delete this code block?
>>
>
> It's not that simple.  This code block is a part
> of worker thread support that is unfinished and
> a long time broken.  So you should either fix it
> or have a good reason to delete it all.
>
>   wbr, Valentin V. Bartenev
>
>
>> On Fri, Sep 26, 2014 at 6:55 PM, Valentin V. Bartenev <vbart at nginx.com> wrote:
>> > On Friday 26 September 2014 17:21:25 XiaoBing Jiang wrote:
>> >> what is the macro meaning?  I can't find any symbol in configure script.
>> >>
>> >
>> > It's meaning:
>> >
>> >   #if 0
>> >       ev->light = 1;
>> >   #endif
>> >
>> > and the ngx_event_t structure has no the "light" member.
>> >
>> >   wbr, Valentin V. Bartenev
>> >
>> >
>> >
>> >> On Tue, Sep 23, 2014 at 4:04 PM, Valentin V. Bartenev <vbart at nginx.com> wrote:
>> >> > On Tuesday 23 September 2014 10:00:06 XiaoBing Jiang wrote:
>> >> >> # HG changeset patch
>> >> >> # User s7v7nislands <s7v7nislands at gmail.com>
>> >> >> # Date 1411437071 -28800
>> >> >> #      Tue Sep 23 09:51:11 2014 +0800
>> >> >> # Branch fix_typo
>> >> >> # Node ID 34a7a94c3dab57fd302fe731b013d90be4354efe
>> >> >> # Parent  a0a14319968b2d978d306f5a91e81e9e4e3e7ce6
>> >> >> Fix typo
>> >> >>
>> >> >> diff -r a0a14319968b -r 34a7a94c3dab src/event/ngx_event_mutex.c
>> >> >> --- a/src/event/ngx_event_mutex.c Mon Sep 22 19:48:23 2014 +0400
>> >> >> +++ b/src/event/ngx_event_mutex.c Tue Sep 23 09:51:11 2014 +0800
>> >> >> @@ -28,7 +28,7 @@
>> >> >>          m->last = ev;
>> >> >>          ev->next = NULL;
>> >> >>
>> >> >> -#if (NGX_THREADS0)
>> >> >> +#if (NGX_THREADS)
>> >> >>          ev->light = 1;
>> >> >>  #endif
>> >> >>
>> >> >
>> >> > No, thanks, that's not a typo.
>> >> >
>> >> >   wbr, Valentin V. Bartenev
>> >> >
>> >> > _______________________________________________
>> >> > nginx-devel mailing list
>> >> > nginx-devel at nginx.org
>> >> > http://mailman.nginx.org/mailman/listinfo/nginx-devel
>> >>
>> >> _______________________________________________
>> >> nginx-devel mailing list
>> >> nginx-devel at nginx.org
>> >> http://mailman.nginx.org/mailman/listinfo/nginx-devel
>> >>
>> >
>> > _______________________________________________
>> > nginx-devel mailing list
>> > nginx-devel at nginx.org
>> > http://mailman.nginx.org/mailman/listinfo/nginx-devel
>>
>> _______________________________________________
>> nginx-devel mailing list
>> nginx-devel at nginx.org
>> http://mailman.nginx.org/mailman/listinfo/nginx-devel
>>
>
> _______________________________________________
> nginx-devel mailing list
> nginx-devel at nginx.org
> http://mailman.nginx.org/mailman/listinfo/nginx-devel



More information about the nginx-devel mailing list