[nginx] Removed the deprecated "so_keepalive" directive.

Ruslan Ermilov ru at nginx.com
Wed Apr 29 12:28:10 UTC 2015


details:   http://hg.nginx.org/nginx/rev/bf1655ae9a1c
branches:  
changeset: 6141:bf1655ae9a1c
user:      Ruslan Ermilov <ru at nginx.com>
date:      Wed Apr 29 13:53:08 2015 +0300
description:
Removed the deprecated "so_keepalive" directive.

diffstat:

 src/mail/ngx_mail.h              |   2 --
 src/mail/ngx_mail_core_module.c  |  16 ----------------
 src/mail/ngx_mail_proxy_module.c |  13 -------------
 3 files changed, 0 insertions(+), 31 deletions(-)

diffs (89 lines):

diff -r 2911b7e5491b -r bf1655ae9a1c src/mail/ngx_mail.h
--- a/src/mail/ngx_mail.h	Wed Apr 29 13:52:49 2015 +0300
+++ b/src/mail/ngx_mail.h	Wed Apr 29 13:53:08 2015 +0300
@@ -131,8 +131,6 @@ typedef struct {
     ngx_msec_t              timeout;
     ngx_msec_t              resolver_timeout;
 
-    ngx_flag_t              so_keepalive;
-
     ngx_str_t               server_name;
 
     u_char                 *file_name;
diff -r 2911b7e5491b -r bf1655ae9a1c src/mail/ngx_mail_core_module.c
--- a/src/mail/ngx_mail_core_module.c	Wed Apr 29 13:52:49 2015 +0300
+++ b/src/mail/ngx_mail_core_module.c	Wed Apr 29 13:53:08 2015 +0300
@@ -27,12 +27,6 @@ static char *ngx_mail_core_resolver(ngx_
     void *conf);
 
 
-static ngx_conf_deprecated_t  ngx_conf_deprecated_so_keepalive = {
-    ngx_conf_deprecated, "so_keepalive",
-    "so_keepalive\" parameter of the \"listen"
-};
-
-
 static ngx_command_t  ngx_mail_core_commands[] = {
 
     { ngx_string("server"),
@@ -56,13 +50,6 @@ static ngx_command_t  ngx_mail_core_comm
       0,
       NULL },
 
-    { ngx_string("so_keepalive"),
-      NGX_MAIL_MAIN_CONF|NGX_MAIL_SRV_CONF|NGX_CONF_FLAG,
-      ngx_conf_set_flag_slot,
-      NGX_MAIL_SRV_CONF_OFFSET,
-      offsetof(ngx_mail_core_srv_conf_t, so_keepalive),
-      &ngx_conf_deprecated_so_keepalive },
-
     { ngx_string("timeout"),
       NGX_MAIL_MAIN_CONF|NGX_MAIL_SRV_CONF|NGX_CONF_TAKE1,
       ngx_conf_set_msec_slot,
@@ -175,7 +162,6 @@ ngx_mail_core_create_srv_conf(ngx_conf_t
 
     cscf->timeout = NGX_CONF_UNSET_MSEC;
     cscf->resolver_timeout = NGX_CONF_UNSET_MSEC;
-    cscf->so_keepalive = NGX_CONF_UNSET;
 
     cscf->resolver = NGX_CONF_UNSET_PTR;
 
@@ -196,8 +182,6 @@ ngx_mail_core_merge_srv_conf(ngx_conf_t 
     ngx_conf_merge_msec_value(conf->resolver_timeout, prev->resolver_timeout,
                               30000);
 
-    ngx_conf_merge_value(conf->so_keepalive, prev->so_keepalive, 0);
-
 
     ngx_conf_merge_str_value(conf->server_name, prev->server_name, "");
 
diff -r 2911b7e5491b -r bf1655ae9a1c src/mail/ngx_mail_proxy_module.c
--- a/src/mail/ngx_mail_proxy_module.c	Wed Apr 29 13:52:49 2015 +0300
+++ b/src/mail/ngx_mail_proxy_module.c	Wed Apr 29 13:53:08 2015 +0300
@@ -111,7 +111,6 @@ static u_char  smtp_auth_ok[] = "235 2.0
 void
 ngx_mail_proxy_init(ngx_mail_session_t *s, ngx_addr_t *peer)
 {
-    int                        keepalive;
     ngx_int_t                  rc;
     ngx_mail_proxy_ctx_t      *p;
     ngx_mail_proxy_conf_t     *pcf;
@@ -121,18 +120,6 @@ ngx_mail_proxy_init(ngx_mail_session_t *
 
     cscf = ngx_mail_get_module_srv_conf(s, ngx_mail_core_module);
 
-    if (cscf->so_keepalive) {
-        keepalive = 1;
-
-        if (setsockopt(s->connection->fd, SOL_SOCKET, SO_KEEPALIVE,
-                       (const void *) &keepalive, sizeof(int))
-                == -1)
-        {
-            ngx_log_error(NGX_LOG_ALERT, s->connection->log, ngx_socket_errno,
-                          "setsockopt(SO_KEEPALIVE) failed");
-        }
-    }
-
     p = ngx_pcalloc(s->connection->pool, sizeof(ngx_mail_proxy_ctx_t));
     if (p == NULL) {
         ngx_mail_session_internal_server_error(s);



More information about the nginx-devel mailing list