[PATCH] http_geo_module: warn when using a variable as the value

Valentin V. Bartenev vbart at nginx.com
Thu Dec 17 11:06:42 UTC 2015


On Wednesday 16 December 2015 23:13:16 Daniel K. wrote:
> Something like this would have saved me a lot of time, hopefully it will
> be of help to others as well.
> 
> But hey, I got an excuse to dive into the nginx code.
> 
> Sorry about the non-'hg export'-ness of the patch.
> I guess Thunderbird will mangle the whitespace, and if you insist I may
> eventually install hg and do it properly, but here goes...
> 
[..]

There are a lot of directives that don't support variables.  If the
directive is support variables, then it is explicitly mentioned in
the documentation.  What is so special about the geo directive?

The patch that adds variables support will have better chances to be
approved than the one that adds a warning.

  wbr, Valentin V. Bartenev



More information about the nginx-devel mailing list