[PATCH] http_geo_module: warn when using a variable as the value

Daniel K. dk at syse.no
Thu Dec 17 13:47:50 UTC 2015


On 12/17/2015 12:44 PM, Maxim Dounin wrote:
> On Wed, Dec 16, 2015 at 11:13:16PM +0000, Daniel K. wrote:
>> Warn when using a variable as the data value in geo blocks
>>
>> Since the geo module does not expand variables, warn when a variable is
>> used as the data value;
> 
> As the geo module is currently probably the only way to insert 
> plain '$' into a place which expands variables, I'm not sure if 
> it's a good idea to add such a patch, at least before we'll 
> resolve the '$' escaping issue.

It was just showing a warning to the possibly unsuspecting user, nothing
else.

Valentin suggested to add variable support. From your comment I take it
that variable support is not wanted, at least not yet, until a machanism
to escape '$' is implemented?


Daniel K.



More information about the nginx-devel mailing list