[PATCH] Http gunzip: additional configuration

Maxim Dounin mdounin at mdounin.ru
Wed Dec 7 15:58:25 UTC 2016


On Sun, Nov 27, 2016 at 02:27:56PM +0200, Alon Blayer-Gat wrote:

> Hi,
> 1) 'gunzip always' option will gunzip even if the client supports it.
> 2) 'gunzip types', like 'always' but only for file types specified
> with 'gunzip_types <mime-types>'
> 3) Allow gunzip and gunzip_types directives within "if in location"
> block (rewrite phase condition).
> The suggested changes are needed, mainly, to allow dynamic
> modification of compressed response (e.g. with the 'sub_filter'
> module)
> 'types' and 'if in location' may allow a more selective operation.

No, thanks.

"If in location" is evil, don't even try to suggest patches to 
allow directives in the "if in location" context.

As for other changes - I can't say I like them as well.  We may 
consider something as simple as "gunzip always", but additional 
types filter certainly looks like an overkill.  Rather it should 
be some more generic mechanism to require gunzipping, may be 
useable by modules directly.


Maxim Dounin

More information about the nginx-devel mailing list