[PATCH] Headers filter: style

Piotr Sikora piotrsikora at google.com
Thu Jun 23 16:53:37 UTC 2016

Hey Maxim,

> I would rather not.  The "hv" is used to refer to a particular
> ngx_http_header_val_t, while "h" here is an array of elements.

But "h" is used throughout the codebase for ngx_table_elt_t, which
makes this particular case confusing.

Also, "h" is used for ngx_table_elt_t regardless of whether it points
to a particular item or an array, so your argument isn't consistent
with the current style.

Best regards,
Piotr Sikora

More information about the nginx-devel mailing list