[PATCH] HTTP/2: add debug logging of control frames
piotrsikora at google.com
Mon Apr 24 23:03:08 UTC 2017
> I actually agree with that, but let's try to reduce the size of printing.
> http2 send SETTINGS frame MAX_CONCURRENT_STREAMS
> http2 send SETTINGS frame INITIAL_WINDOW_SIZE
> http2 send SETTINGS frame MAX_FRAME_SIZE
> This looks like too verbose for just one SETTINGS frame.
What do you suggest instead? All 3 params in the same line?
http2 send SETTINGS frame MAX_CONCURRENT_STREAMS:%ui
What about receiving part, then? Do you want to put all 6 params in
the same line?
http2 recv SETTINGS frame HEADER_TABLE_SIZE:%ui (ignored)
ENABLE_PUSH:%ui (ignored) MAX_CONCURRENT_STREAMS:%ui (ignored)
INITIAL_WINDOW_SIZE:%ui MAX_FRAME_SIZE:%ui MAX_HEADER_LIST_SIZE:%ui
It makes this way less readable, IMHO.
> Also, literally
> reading these lines can be misinterpreted as sending multiple SETTINGS
That's because you skipped the first line, i.e.:
http2 send SETTINGS frame params:3
http2 send SETTINGS frame MAX_CONCURRENT_STREAMS
http2 send SETTINGS frame INITIAL_WINDOW_SIZE
http2 send SETTINGS frame MAX_FRAME_SIZE
More information about the nginx-devel