Add support for buffering is scripted logs
mdounin at mdounin.ru
Mon Aug 14 17:33:46 UTC 2017
On Mon, Aug 14, 2017 at 05:11:22PM +0000, Eran Kornblau wrote:
> > -----Original Message-----
> > From: nginx-devel [mailto:nginx-devel-bounces at nginx.org] On Behalf Of Maxim Dounin
> > Sent: Monday, August 14, 2017 7:55 PM
> > To: nginx-devel at nginx.org
> > Subject: Re: Add support for buffering is scripted logs
> > Hello!
> > On Mon, Aug 14, 2017 at 04:01:10PM +0000, Eran Kornblau wrote:
> > > Thanks Maxim, comments inline.
> > >
> > > > Hello!
> > > >
> > > > On Mon, Aug 07, 2017 at 10:36:19AM +0000, Eran Kornblau wrote:
> > > >
> > > > Just a quick note: for me, the whole feature looks questionable, and the implementation is far from being in a commitable state.
> > > >
> > > Why questionable? you would probably agree that variables in the
> > > access log name can be useful in some cases, and you'd probably also
> > > agree that log compression is good (it saves a lot of IO for a negligible amount of CPU - we use it in all nginx servers we have). So why not allow both?
> > Obviously enough, every feature you can think of is useful in some cases. The question is code complexity and other maintanance expenses compared to the usefulness of the particular feature.
> Ok, so is that a final 'no' for this whole feature, or is there is anything else I can do to get this feature in?
It is certainly not a "final no". As I wrote in the very first
comment, a) it's just a quick note, nothing more, and b) the
feature is questionable. If a good implementation will be
submitted, we can consider committing it.
More information about the nginx-devel