[PATCH] Proxy: make timeout directives accept variables

Maxim Dounin mdounin at mdounin.ru
Tue Jan 31 16:00:42 UTC 2017


On Mon, Jan 30, 2017 at 05:39:13PM -0800, Thibault Charbonnier wrote:

> This is a proposal to allow for better granularity (eventually, on a 
> per-request basis?) regarding the proxy_*_timeout directives.
> Please let me know how you feel about such a feature, and if you think 
> this patch should be implemented in a different way.

I can't say I like the patch as it introduces a lot of code 
without obvious reasons.  Not to mention it only covers proxy, 
while there are also memcached, fastcgi, scgi, and uwsgi.

You may want to provide more details on what problem you are 
trying to solve.


> If a timeout directive contains a variable, we consider such variable to
> contain the related timeout in ms precision.

Just a side note: this is certainly wrong, it should follow the 
same rules as normal parsing of the directive.

Maxim Dounin

More information about the nginx-devel mailing list