Fwd: Patch. Add new directive '2square' for image_filter

Maxim Dounin mdounin at mdounin.ru
Tue Jul 4 14:41:44 UTC 2017


On Wed, Jun 28, 2017 at 11:33:05PM +0300, Иван Иванов wrote:

> Add new directive '2square' to image_filter, which resizes and converts
> image in square and add white border. It's cood be usefull for convert
> image for facebook banners.
> In attach:
> nginx.patch - patch for main repo (http://hg.nginx.org/nginx),
> image_filter_2square.t -  file with tests for (http://hg.nginx.org/nginx-
> tests)
> nginx_org.patch - docs for (http://hg.nginx.org/nginx.org/)

Thanks you for your patches.  Could you please clarify how this 
functionality is expected to be used?

>From the description and the code it looks very specific for a 
particular use case, and it might be a good idea to introduce 
something more generic instead and/or use existing functions 
combined with HTML rendering to achieve the same effect.

Maxim Dounin

More information about the nginx-devel mailing list