[PATCH] HTTP/2: add support for HPACK encoding
Valentin V. Bartenev
vbart at nginx.com
Mon Jul 24 23:26:44 UTC 2017
On Monday 24 July 2017 12:33:55 Vlad Krasnov via nginx-devel wrote:
> >> + ngx_http_v2_hpack_enc_entry_t htable[HPACK_ENC_HTABLE_SZ];
> >> + ngx_http_v2_hpack_name_entry_t heads[HPACK_ENC_DYNAMIC_KEY_TBL_SZ];
> >> + u_char storage[NGX_HTTP_V2_MAX_HPACK_TABLE_SIZE +
> >> + HPACK_ENC_MAX_ENTRY];
> >> +} ngx_http_v2_hpack_enc_t;
> >> +#endif
> >> +
> >> +
> > Well, it means that even idle connection will consume 18+ KB more
> > memory than before.
> > That doesn't look like a generic solution suitable for most of our users.
> > It should be at least configurable.
> I can make it configurable fairly easily, but then it will require an extra allocation.
With your current patch ngx_http_v2_connection_s doesn't fit into
memory pool anymore and requires an extra allocation anyway.
wbr, Valentin V. Bartenev
More information about the nginx-devel