[PATCH 1 of 4] HTTP/2: emit new frames only after applying all SETTINGS params

Piotr Sikora piotrsikora at google.com
Thu Jun 1 21:55:06 UTC 2017

Hey Valentin,

> The new initial window size can be lower than the previous one,
> so the difference can be negative (that's why the delta parameter
> of ngx_http_v2_adjust_windows() is ssize_t).

Oops, good catch, thanks!

Funnily enough, the original patch worked just fine (at least on
systems where size of ssize_t was equal to size of ngx_uint_t), since
the value would overflow and result in the same negative number when
casted to ssize_t.

I updated patchset with suggested changes, please take a look.

Best regards,
Piotr Sikora

More information about the nginx-devel mailing list