[PATCH 2 of 3] HTTP/2: added support for trailers in HTTP responses
piotrsikora at google.com
Tue Jun 13 12:24:31 UTC 2017
> It's better to keep return values consistent with
> ngx_http_v2_create_headers_frame() and introduce
> NGX_HTTP_V2_NO_TRAILERS instead of NGX_HTTP_V2_FRAME_ERROR.
NGX_HTTP_V2_NO_TRAILERS feels a bit weird, but whatever works for you is fine.
> There's no reason to check "trailers" on each iteration.
> I think you can put it inside the "if (in == NULL)" condition.
Good catch, thanks!
> Please consider the changes below.
Applied (with removed empty lines between error message and "return NULL").
More information about the nginx-devel