mdounin at mdounin.ru
Wed Jun 14 19:16:07 UTC 2017
On Wed, Jun 14, 2017 at 01:10:55AM +0000, Karstens, Nate wrote:
> OK, sounds good to me! I'll hopefully have some new patches
> available in a couple of days.
> Any thoughts on using regular expressions to validate the format
> of the password file and extract strings? Specifically, does any
> string matching have to use regular expressions (protected by
> NGX_PCRE), or is the use of regular expressions optional?
In general nginx doesn't use regular expressions internally, as
usually there are better ways to validate things. Also, it is
expected to work fine without regular expressions, so using
regular expressions to validate anything means that the feature
won't be available without pcre compiled in.
If you are looking for ways to simplify the patch, consider only
preserving plain-text secrets, and/or using Base64 instead of
hex (as there is standard ngx_decode_base64() function available).
More information about the nginx-devel