[PATCH] Output chain: propagate flush and last_buf flags to send_chain()

Piotr Sikora piotrsikora at google.com
Sat Jun 17 20:58:27 UTC 2017

Hey Maxim,

> Note well that in HTTP/2-related code the special flag
> c->need_last_buf is used to indicate that a (fake) connection
> needs an information about last_buf, thus allowing HTTP/2
> c->send_chain() wrapper to add its own framing.  If the goal is
> the same, please consider using the same approach.

Yes, it's exactly the same use case.

I originally used c->need_last_buf, but then decided against it, since
c->send_chain() is "pluggable" and therefore we shouldn't be assuming
it's behavior, but I don't mind either way, as both solutions for work
my use case.

Best regards,
Piotr Sikora

More information about the nginx-devel mailing list