[PATCH] HTTP/2: add logging of RST_STREAM frames with NO_ERROR code

Piotr Sikora piotrsikora at google.com
Thu Mar 30 00:58:54 UTC 2017

Hey Valentin,

> Currently such frames are logged with message:
>   "client terminated stream %ui with status 0"
> Could you explain why NO_ERROR needs special handling here?

The same reason that "client canceled stream %ui" does, it's more
appropriate error message.

> I haven't found in RFC mentions about cases in which clients can
> send RST_STREAM with NO_ERROR.

I believe that clients can send RST_STREAM with NO_ERROR when they are
satisfied with the response they received, but didn't receive
END_STREAM flag yet. One example of such behavior might be a client
that received all DATA frames (as indicated by Content-Length or other
application-level mechanism) but is still waiting on HEADERS frame
(with trailers), that it doesn't care about.

Note that this is more theoretical scenario and I'm not aware of any
popular clients doing this right now.

Best regards,
Piotr Sikora

More information about the nginx-devel mailing list