[PATCH] Clarify proxy modules $proxy_host variable content

Maxim Dounin mdounin at mdounin.ru
Tue Dec 18 16:14:27 UTC 2018


On Tue, Dec 18, 2018 at 10:21:31AM +0100, Jack Henschel wrote:

> Good Morning,
> On 12/10/18 6:38 PM, Maxim Dounin wrote:
> > Hello!
> > 
> > On Tue, Dec 04, 2018 at 05:00:10PM +0100, Jack Henschel wrote:
> > 
> >> From the current documentation it was not immediately obvious (at least
> >> to me and my colleague) that nginx does not set the $proxy_host variable
> >> to the hosts specified in an upstream block, but literally uses the name
> >> used in the proxy_pass directive.
> >>
> >> Maxim Dounin has explained to me the reason for this [1], nevertheless I
> >> think it is worthwhile explicitly adding this behavior to the documentation.
> > 
> > Thank you for your patch.  It looks too explicit for me though.
> > 
> That's the point though: to be _explicit_ about this behavior.
> I have talked to a few of my colleagues and none of them regarded it as
> obvious.

While this may not be obvious, this is a logical result of how 
things work.  Further, this is something already explicitly 
written.  And the challenge is to make it obvious and logical, 
rather simply stating something again.

(Just in case, Yaroslav Zhuravlev already tried to introduce the 
DNS analogy I've used in my explanation to you, but failed to 
produce something committable as well.)

Maxim Dounin

More information about the nginx-devel mailing list