[PATCH] Core: remove unused FIOASYNC.
ru at nginx.com
Thu Jun 28 09:27:40 UTC 2018
On Wed, Jun 27, 2018 at 01:40:26PM -0700, Ian Gudger wrote:
> Sorry, I understand now.
> Here is a new patch which removes that too:
> # HG changeset patch
> # User Ian Gudger <igudger at google.com>
> # Date 1529449008 25200
> # Tue Jun 19 15:56:48 2018 -0700
> # Node ID 8fd0b85081a1cb91fa4495258bb5f9d3a6ef5785
> # Parent 118885f7a5774962f1145693d9c26a4c199ca6ea
> Core: remove FIOASYNC as the SIGIOs it generated were ignored.
> FIOASYNC and F_SETOWN cause a pid or pgid to receive signals when a file is
> ready for IO. When using master process mode, this was setup, but the SIGIO
> signals were ignored. This has been the case since use of FIOASYNC was first
> added in eaf1f651cf86. Logic ignore the SIGIOs in a case where they
> unintentionally did something was added in 8abb88374c6c.
> diff --git a/src/os/unix/ngx_process.c b/src/os/unix/ngx_process.c
> @@ -433,8 +411,6 @@ ngx_signal_handler(int signo, siginfo_t
> case ngx_signal_value(NGX_RECONFIGURE_SIGNAL):
> case ngx_signal_value(NGX_CHANGEBIN_SIGNAL):
> - case SIGIO:
> - action = ", ignoring";
On Wed, Jun 27, 2018 at 03:57:05PM +0300, Ruslan Ermilov wrote:
> Removing setting of an "action" variable looks like an error.
No need to resend the patch.
More information about the nginx-devel