[PATCH] Range filter: always support ascending multipart ranges.

Maxim Dounin mdounin at mdounin.ru
Tue Apr 23 16:45:20 UTC 2019


Hello!

On Mon, Apr 22, 2019 at 09:51:49AM -0700, Robert Burke wrote:

> Hello,
> 
> I'd love to hear any comments about this :)
> 
> On Thu, Apr 11, 2019 at 5:51 AM Robert Burke <sharpobject at gmail.com> wrote:
> >
> > Hello,
> >
> > At Cloudflare we'd like to support multiple byte-ranges if they are
> > non-overlapping and in ascending order on cache miss or when using
> > slice. This patch adds support for that. It preserves the existing
> > multipart range support for response bodies that are in a single
> > buffer. It does not remove buffers from the passed-in chain, which
> > seems like it was the biggest issue mdounin raised with the previous
> > patch.

Actually, the biggest issue is "if it worth the added complexity", 
and issues with the patch as originally reviewed[1] was an 
additional reason to say "no".

If you think you want to add support nevertheless, you may want to 
elaborate more on why you need it.  In my practice there are very 
few legitimate users of multipart ranges, and at least some of 
these actually benefit from disabling ranges support completely.

[1] http://mailman.nginx.org/pipermail/nginx-devel/2017-November/010623.html

-- 
Maxim Dounin
http://mdounin.ru/


More information about the nginx-devel mailing list