[nginx] Disabled connection reuse while in SSL handshake.

[Sergey Kandaurov]

details:   https://hg.nginx.org/nginx/rev/2e3bfd696ecb
branches:  
changeset: 7628:2e3bfd696ecb
user:      Sergey Kandaurov <pluknet at nginx.com>
date:      Thu Feb 27 19:03:21 2020 +0300
description:
Disabled connection reuse while in SSL handshake.

During SSL handshake, the connection could be reused in the OCSP stapling
callback, if configured, which subsequently leads to a segmentation fault.

diffstat:

 src/http/ngx_http_request.c |  4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diffs (21 lines):

diff -r 4f18393a1d51 -r 2e3bfd696ecb src/http/ngx_http_request.c
--- a/src/http/ngx_http_request.c	Thu Feb 20 16:51:07 2020 +0300
+++ b/src/http/ngx_http_request.c	Thu Feb 27 19:03:21 2020 +0300
@@ -748,6 +748,8 @@ ngx_http_ssl_handshake(ngx_event_t *rev)
                 return;
             }
 
+            ngx_reusable_connection(c, 0);
+
             rc = ngx_ssl_handshake(c);
 
             if (rc == NGX_AGAIN) {
@@ -756,8 +758,6 @@ ngx_http_ssl_handshake(ngx_event_t *rev)
                     ngx_add_timer(rev, c->listening->post_accept_timeout);
                 }
 
-                ngx_reusable_connection(c, 0);
-
                 c->ssl->handler = ngx_http_ssl_handshake_handler;
                 return;
             }