[nginx] HTTP/2: removed ngx_debug_point() call.

Ruslan Ermilov ru at nginx.com
Tue Jan 14 11:21:41 UTC 2020


details:   https://hg.nginx.org/nginx/rev/8a7b59347401
branches:  
changeset: 7618:8a7b59347401
user:      Daniil Bondarev <bondarev at amazon.com>
date:      Tue Jan 14 14:20:08 2020 +0300
description:
HTTP/2: removed ngx_debug_point() call.
    
With the recent change to prevent frames flood in d4448892a294,
nginx will finalize the connection with NGX_HTTP_V2_INTERNAL_ERROR
whenever flood is detected, causing nginx aborting or stopping if
the debug_points directive is used in nginx config.

diffstat:

 src/http/v2/ngx_http_v2.c |  4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diffs (14 lines):

diff -r f1720934c45b -r 8a7b59347401 src/http/v2/ngx_http_v2.c
--- a/src/http/v2/ngx_http_v2.c	Fri Dec 27 19:43:01 2019 +0300
+++ b/src/http/v2/ngx_http_v2.c	Tue Jan 14 14:20:08 2020 +0300
@@ -2466,10 +2466,6 @@ ngx_http_v2_connection_error(ngx_http_v2
     ngx_log_debug0(NGX_LOG_DEBUG_HTTP, h2c->connection->log, 0,
                    "http2 state connection error");
 
-    if (err == NGX_HTTP_V2_INTERNAL_ERROR) {
-        ngx_debug_point();
-    }
-
     ngx_http_v2_finalize_connection(h2c, err);
 
     return NULL;


More information about the nginx-devel mailing list