[nginx] gRPC: RST_STREAM(NO_ERROR) handling after "trailer only" responses.

[Pavel Pautov]

details:   https://hg.nginx.org/nginx/rev/88eca63261c3
branches:  
changeset: 7746:88eca63261c3
user:      Pavel Pautov <p.pautov at f5.com>
date:      Wed Nov 18 18:41:16 2020 -0800
description:
gRPC: RST_STREAM(NO_ERROR) handling after "trailer only" responses.

Similarly to the problem fixed in 2096b21fcd10 (ticket #1792),
when a "trailer only" gRPC response (that is, a response with the
END_STREAM flag in the HEADERS frame) was immediately followed by
RST_STREAM(NO_ERROR) in the data preread along with the response
header, RST_STREAM wasn't properly skipped and caused "upstream
rejected request with error 0" errors.
Observed with "unknown service" gRPC errors returned by grpc-go.

Fix is to set ctx->done if we are going to parse additional data,
so the RST_STREAM(NO_ERROR) is properly skipped.  Additionally, now
ngx_http_grpc_filter() will complain about frames sent for closed
stream if there are any.

diffstat:

 src/http/modules/ngx_http_grpc_module.c |  1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diffs (11 lines):

diff -r f57a478aa16d -r 88eca63261c3 src/http/modules/ngx_http_grpc_module.c
--- a/src/http/modules/ngx_http_grpc_module.c	Thu Nov 19 17:15:22 2020 +0000
+++ b/src/http/modules/ngx_http_grpc_module.c	Wed Nov 18 18:41:16 2020 -0800
@@ -1969,6 +1969,7 @@ ngx_http_grpc_filter_init(void *data)
         }
 
         u->length = 0;
+        ctx->done = 1;
 
     } else {
         u->length = 1;