Re: [PATCH] Core: fixed inconsistent state of subrequest's headers_in list

[Maxim Dounin]

Hello!

On Thu, Nov 26, 2020 at 09:11:39PM +0100, Jan Prachař wrote:

> # HG changeset patch
> # User Jan Prachař  <jan.prachar at gmail.com>
> # Date 1606420825 -3600
> #      Thu Nov 26 21:00:25 2020 +0100
> # Node ID cf3d537ec6706f8713a757df256f2cfccb8f9b01
> # Parent  e35b529b03781e64912e0d8a72bd0f957dc08cd2
> Core: fixed inconsistent state of subrequest's headers_in list
> 
> When copying structure ngx_list_t, a reference to the last part need to be
> updated, if list contains only one part.
> 
> This fixes an issue, when adding a header to the subrequest's headers_in list
> has no effect.

Thank you for your patch.

Modules are not expected to modify r->headers_in.  Instead, 
consider using appropriate directives to set headers in upstream 
requests, notably proxy_set_header.

[...]

-- 
Maxim Dounin
http://mdounin.ru/