<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN">
<html><body style='font-size: 10pt; font-family: Verdana,Geneva,sans-serif'>
<p>Thx, and sorry for your effort.</p>
<p>I speak "git" (stumble over "hg" sometimes:)</p>
<p>Your patch was a little bit broken:<br /> * dual ``` return NGX_OK; ``` in line 135 after debug;<br /> * line 157: ``` if (UnmapViewOfFile(shm->addr) == 0) { ``` should be removed.</p>
<p>New changeset attached.</p>
<p>BTW: pure C comments are imho rudiments, because these prevent a (temporary) commenting of larger code blocks. That's why I try to avoid these - just pure habit.</p>
<p>And really 80 cols (and CRLF-problem) in 21st century?</p>
<p>But, once again sorry and thanks.</p>
<p>Regargs,<br />sebres.</p>
<p>Am 22.04.2015 10:57, schrieb Filipe DA SILVA:</p>
<blockquote type="cite" style="padding-left:5px; border-left:#1010ff 2px solid; margin-left:5px"><!-- html ignored --><!-- head ignored --><!-- meta ignored --><!-- meta ignored --><!-- node type 8 --><!-- node type 8 --><!-- node type 8 -->
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size: 11.0pt; font-family: 'Calibri','sans-serif'; color: #1f497d;">Hi,<!-- o ignored --></span></p>
<p class="MsoNormal"><span style="font-size: 11.0pt; font-family: 'Calibri','sans-serif'; color: #1f497d;"><!-- o ignored --> </span></p>
<p class="MsoNormal"><span style="font-size: 11.0pt; font-family: 'Calibri','sans-serif'; color: #1f497d;">Please find attach a quickly reworked version of your patch .<!-- o ignored --></span></p>
<p class="MsoNormal"><span style="font-size: 11.0pt; font-family: 'Calibri','sans-serif'; color: #1f497d;"><!-- o ignored --> </span></p>
<p class="MsoNormal"><span style="font-size: 11.0pt; font-family: 'Calibri','sans-serif'; color: #1f497d;">I forget to speak about th 80 cols limits.<!-- o ignored --></span></p>
<p class="MsoNormal"><span style="font-size: 11.0pt; font-family: 'Calibri','sans-serif'; color: #1f497d;"><!-- o ignored --> </span></p>
<p class="MsoNormal"><span style="font-size: 11.0pt; font-family: 'Calibri','sans-serif'; color: #1f497d;">Regards,<!-- o ignored --></span></p>
<p class="MsoNormal"><span style="font-size: 11.0pt; font-family: 'Calibri','sans-serif'; color: #1f497d;">Filipe DA SILVA<!-- o ignored --></span></p>
<p class="MsoNormal"><span style="font-size: 11.0pt; font-family: 'Calibri','sans-serif'; color: #1f497d;"><!-- o ignored --> </span></p>
<p class="MsoNormal"><span style="font-size: 11.0pt; font-family: 'Calibri','sans-serif'; color: #1f497d;"><!-- o ignored --> </span></p>
<div>
<div style="border: none; border-top: solid #B5C4DF 1.0pt; padding: 3.0pt 0cm 0cm 0cm;">
<p class="MsoNormal"><strong><span style="font-size: 10.0pt; font-family: 'Tahoma','sans-serif';">De :</span></strong><span style="font-size: 10.0pt; font-family: 'Tahoma','sans-serif';"> nginx-devel-bounces@nginx.org [mailto:nginx-devel-bounces@nginx.org] <strong>De la part de</strong> Sergey Brester<br /><strong>Envoyé :</strong> mercredi 22 avril 2015 09:46<br /><strong>À :</strong> nginx-devel@nginx.org<br /><strong>Objet :</strong> Fwd: Windows shmem fix: makes shared memory fully ASLR and DEP compliant (ea. cache zone, limit zone, etc.)<!-- o ignored --></span></p>
</div>
</div>
<p class="MsoNormal"><!-- o ignored --> </p>
<p><span style="font-size: 10.0pt; font-family: 'Verdana','sans-serif';">Hi,<!-- o ignored --></span></p>
<p><span style="font-size: 10.0pt; font-family: 'Verdana','sans-serif';">enclosed you will find an attached changeset, that fixes a ASLR/DEP problem on windows platforms (example Win 7/2008 x64).<!-- o ignored --></span></p>
<p><span style="font-size: 10.0pt; font-family: 'Verdana','sans-serif';">To find shared addr offset with ASLR, we have successful used the same resp. similar solution on various open source projects (ex.: postgresql etc.). Also nginx with suggested patch works fine over 5 months in production on several machines (Win-2k8-R2).<!-- o ignored --></span></p>
<p><span style="font-size: 10.0pt; font-family: 'Verdana','sans-serif';">BTW(1): I have interest to fix a problem with multiple workers under windows (ex.: <a href="http://forum.nginx.org/read.php?2,188714,188714#msg-188714">http://forum.nginx.org/read.php?2,188714,188714#msg-188714</a>).<br /> @Maxim Dounin: can you possibly give me more information, what you mean here, resp. what it currently depends on (see <a href="http://forum.nginx.org/read.php?2,188714,212568#msg-212568">http://forum.nginx.org/read.php?2,188714,212568#msg-212568</a>).<!-- o ignored --></span></p>
<p style="margin-bottom: 12.0pt;"><span style="font-size: 10.0pt; font-family: 'Verdana','sans-serif';">BTW(2): I would like to fix iocp under windows also. Thanks in advance for any information about.<!-- o ignored --></span></p>
<p><span style="font-size: 10.0pt; font-family: 'Verdana','sans-serif';">P.S. speak fluently russian and german...<br /><br /><br /> Regards,<!-- o ignored --></span></p>
<p><span style="font-size: 10.0pt; font-family: 'Verdana','sans-serif';">Serg G. Brester (sebres)<!-- o ignored --></span></p>
<div class="MsoNormal"><hr align="left" size="1" width="50%" /></div>
</div>
</blockquote>
</body></html>