<div dir="ltr">OK ,thanks for your explanation.</div><div class="gmail_extra"><br><div class="gmail_quote">2018-04-24 17:02 GMT+08:00 Ruslan Ermilov <span dir="ltr"><<a href="mailto:ru@nginx.com" target="_blank">ru@nginx.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<div><div class="h5"><br>
On Tue, Apr 24, 2018 at 04:33:15PM +0800, Peng Fang wrote:<br>
> # HG changeset patch<br>
> # User peng fang <<a href="mailto:fangpeng1986@gmail.com">fangpeng1986@gmail.com</a>><br>
> # Date 1524558323 -28800<br>
> # Node ID 5b84c8dc4cf5e909673adc24e044a7<wbr>644da7f8d5<br>
> # Parent  7c614ef3c6ea330c62630d5065f961<wbr>a27d0f82cd<br>
> Style.<br>
> <br>
> Fix style broken by 3a8a53c0c42f.<br>
> <br>
> diff -r 7c614ef3c6ea -r 5b84c8dc4cf5 src/http/ngx_http_cache.h<br>
> --- a/src/http/ngx_http_cache.h Wed Apr 18 16:11:41 2018 +0300<br>
> +++ b/src/http/ngx_http_cache.h Tue Apr 24 16:25:23 2018 +0800<br>
> @@ -191,7 +191,7 @@<br>
>  ngx_int_t ngx_http_file_cache_set_<wbr>header(ngx_http_request_t *r, u_char<br>
> *buf);<br>
>  void ngx_http_file_cache_update(<wbr>ngx_http_request_t *r, ngx_temp_file_t<br>
> *tf);<br>
>  void ngx_http_file_cache_update_<wbr>header(ngx_http_request_t *r);<br>
> -ngx_int_t ngx_http_cache_send(ngx_http_<wbr>request_t *);<br>
> +ngx_int_t ngx_http_cache_send(ngx_http_<wbr>request_t *r);<br>
>  void ngx_http_file_cache_free(ngx_<wbr>http_cache_t *c, ngx_temp_file_t *tf);<br>
>  time_t ngx_http_file_cache_valid(ngx_<wbr>array_t *cache_valid, ngx_uint_t<br>
> status);<br>
<br>
</div></div>Thanks for your patch.  It is incomplete:<br>
<br>
diff --git a/src/http/modules/ngx_http_<wbr>ssi_filter_module.h b/src/http/modules/ngx_http_<wbr>ssi_filter_module.h<br>
--- a/src/http/modules/ngx_http_<wbr>ssi_filter_module.h<br>
+++ b/src/http/modules/ngx_http_<wbr>ssi_filter_module.h<br>
@@ -85,7 +85,7 @@ typedef struct {<br>
<br>
<br>
 typedef ngx_int_t (*ngx_http_ssi_command_pt) (ngx_http_request_t *r,<br>
-    ngx_http_ssi_ctx_t *ctx, ngx_str_t **);<br>
+    ngx_http_ssi_ctx_t *ctx, ngx_str_t **params);<br>
<br>
<br>
 typedef struct {<br>
diff --git a/src/http/ngx_http.h b/src/http/ngx_http.h<br>
--- a/src/http/ngx_http.h<br>
+++ b/src/http/ngx_http.h<br>
@@ -159,7 +159,7 @@ ngx_int_t ngx_http_set_default_types(ngx<br>
     ngx_str_t *default_type);<br>
<br>
 #if (NGX_HTTP_DEGRADATION)<br>
-ngx_uint_t  ngx_http_degraded(ngx_http_<wbr>request_t *);<br>
+ngx_uint_t  ngx_http_degraded(ngx_http_<wbr>request_t *r);<br>
 #endif<br>
<br>
<br>
The patch above shows another style issue within nginx:<br>
<br>
$ grep -r 'typedef.*pt)(' src | wc -l<br>
54<br>
$ grep -r 'typedef.*pt) (' src | wc -l<br>
26<br>
<br>
Note that nginx code now has a lot of violations of its own<br>
code style.<br>
<br>
Please DO NOT send us style fixing patches, we won't commit<br>
them just for the sake of fixing style.  Only do so if you<br>
notice the style violation while working on the code, then<br>
you MAY send the style fixing patch as a preparatory one in<br>
the patch series.<br>
______________________________<wbr>_________________<br>
nginx-devel mailing list<br>
<a href="mailto:nginx-devel@nginx.org">nginx-devel@nginx.org</a><br>
<a href="http://mailman.nginx.org/mailman/listinfo/nginx-devel" rel="noreferrer" target="_blank">http://mailman.nginx.org/<wbr>mailman/listinfo/nginx-devel</a><br>
</blockquote></div><br></div>