<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Hi Maxim,</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Thank you. By "production version" I meant the current release version, which if I recall correctly, is 1.17.1.</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Ok. So then you recommend I copy the code that processes the If-Range header to determine if the If-Range is valid? I can then use those functions to determine the extent of the range, which is what I need to know.</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div id="Signature"><span style="color:black">Carey Gister</span>
<div><span style="color:black">415-310-5304<br>
</span> </div>
<div>
<div id="appendonsend"></div>
<div style="font-family:Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> nginx-devel <nginx-devel-bounces@nginx.org> on behalf of Maxim Dounin <mdounin@mdounin.ru><br>
<b>Sent:</b> Tuesday, July 2, 2019 15:52<br>
<b>To:</b> nginx-devel@nginx.org<br>
<b>Subject:</b> Re: Bug in ngx_http_slice_filter_module ngx_http_slice_parse_content_range function</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt">
<div class="PlainText">Hello!<br>
<br>
On Mon, Jul 01, 2019 at 10:07:41PM +0000, Carey Gister wrote:<br>
<br>
> Thank you for your reply. My use case is as follows:<br>
> <br>
> After the slice header filter calls ngx_http_next_header_filter <br>
> the contents of the request headers_out fields will be modified <br>
> if an If-Range header is valid. The production version of the <br>
> slice header filter already relies on the modified headers_out <br>
> fields set by the range filter.<br>
<br>
It is not clear what do you mean by "the production version", but <br>
the slice header filter as available in nginx calls next filter <br>
only after parsing r->header_out.content_range header. That is, <br>
it uses Content-Range header from a backend response, not the one <br>
set by the range header filter.<br>
<br>
> My extension needs to know the bounds of the new range IF the <br>
> If-Range header is valid. So I parse the new content_range value <br>
> using the ngx_http_slice_parse_content_range function to return <br>
> the stored values.<br>
<br>
So, you are misusing the ngx_http_slice_parse_content_range() <br>
function for something it's not intended for.<br>
<br>
> If this is incorrect, then please tell me how I can know if the <br>
> If-Range header is valid, preferably without duplicating the <br>
> code in the range filter, and if it is valid, what the correct <br>
> range values will be.<br>
<br>
I don't think there is a good way.<br>
<br>
-- <br>
Maxim Dounin<br>
<a href="http://mdounin.ru/">http://mdounin.ru/</a><br>
_______________________________________________<br>
nginx-devel mailing list<br>
nginx-devel@nginx.org<br>
<a href="http://mailman.nginx.org/mailman/listinfo/nginx-devel">http://mailman.nginx.org/mailman/listinfo/nginx-devel</a><br>
</div>
</span></font></div>
</div>
</div>
</body>
</html>