<div dir="ltr">> The patch wasn't updated since that but I suspect it could be still<br>applied to nginx, maybe with some minor tweaks.<br><div><br></div><div>We still appreciate your work. </div><div><br></div><div>BTW, are the patches in the attachment up to date?</div><div>If not, can you share the latest patch?</div><div>We are happy to apply it and feedback if possible.</div><div>When there are many static files and accesses, do you think it will works very well?</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, Jul 20, 2019 at 2:42 AM Maxim Konovalov <<a href="mailto:maxim@nginx.com">maxim@nginx.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi hongzhidao,<br>
<br>
The patch wasn't merged as we didn't see much interest and real<br>
technical feedback from potential testers.<br>
<br>
The code adds additional complexity to the nginx core with all<br>
associated costs of maintaining the code virtually forever. In the<br>
same time at this point it brings no measurable value to the<br>
community. At least, we haven't seen any proofs that it does.<br>
<br>
The patch wasn't updated since that but I suspect it could be still<br>
applied to nginx, maybe with some minor tweaks.<br>
<br>
Maxim<br>
<br>
On 19/07/2019 18:26, 洪志道 wrote:<br>
> Hi.<br>
> Will this patch be merged into the main branch?<br>
> What is the latest patch? We can help with the test.<br>
> Thanks.<br>
> <br>
> On Sat, Feb 9, 2019 at 6:40 AM Ka-Hing Cheung via nginx-devel<br>
> <<a href="mailto:nginx-devel@nginx.org" target="_blank">nginx-devel@nginx.org</a> <mailto:<a href="mailto:nginx-devel@nginx.org" target="_blank">nginx-devel@nginx.org</a>>> wrote:<br>
> <br>
> Unfortunately our test colo is not setup to do performance testing<br>
> (the traffic it receives varies too much). We do intend to merge<br>
> this<br>
> to our production colos but there's no timeline yet.<br>
> <br>
> Yuchen (CC'ed) will be the main contact from now on as today is my<br>
> last day at Cloudflare.<br>
> <br>
> - Ka-Hing<br>
> <br>
> On Thu, Feb 7, 2019 at 5:39 AM Maxim Konovalov <<a href="mailto:maxim@nginx.com" target="_blank">maxim@nginx.com</a><br>
> <mailto:<a href="mailto:maxim@nginx.com" target="_blank">maxim@nginx.com</a>>> wrote:<br>
> ><br>
> > Great. Thanks for the testing!<br>
> ><br>
> > Did you see any measurable perf. metrics changes comparing to your<br>
> > aio open implementation or comparing to nginx without aio open<br>
> support?<br>
> ><br>
> > We are still waiting for additional input from another tester, who<br>
> > expressed interest before.<br>
> ><br>
> > Thanks,<br>
> ><br>
> > Maxim<br>
> ><br>
> > On 07/02/2019 00:19, Ka-Hing Cheung wrote:<br>
> > > This has been running in our test colo for the past week<br>
> with no ill effects.<br>
> > ><br>
> > > On Wed, Jan 23, 2019 at 4:39 AM Maxim Konovalov<br>
> <<a href="mailto:maxim@nginx.com" target="_blank">maxim@nginx.com</a> <mailto:<a href="mailto:maxim@nginx.com" target="_blank">maxim@nginx.com</a>>> wrote:<br>
> > >><br>
> > >> Hi Ka-Hing,<br>
> > >><br>
> > >> Roman told me that the delta is because of your changes.<br>
> > >><br>
> > >> Thanks for your time on that. Waiting for your testing<br>
> results.<br>
> > >><br>
> > >> Maxim<br>
> > >><br>
> > >> On 22/01/2019 22:34, Ka-Hing Cheung via nginx-devel wrote:<br>
> > >>> I spoke too soon, just realized our test colo is running<br>
> the patches<br>
> > >>> without aio_open on. Flipping that switch now.<br>
> > >>><br>
> > >>> Also, including the patch that we applied on top in<br>
> addition to the<br>
> > >>> massaging we did to resolve conflicts. I haven't dug too<br>
> deep to see<br>
> > >>> if stock nginx also requires similar changes or they are only<br>
> > >>> necessary because of our other nginx changes:<br>
> > >>><br>
> > >> [...]<br>
> > >><br>
> > >> --<br>
> > >> Maxim Konovalov<br>
> ><br>
> ><br>
> > --<br>
> > Maxim Konovalov<br>
> _______________________________________________<br>
> nginx-devel mailing list<br>
> <a href="mailto:nginx-devel@nginx.org" target="_blank">nginx-devel@nginx.org</a> <mailto:<a href="mailto:nginx-devel@nginx.org" target="_blank">nginx-devel@nginx.org</a>><br>
> <a href="http://mailman.nginx.org/mailman/listinfo/nginx-devel" rel="noreferrer" target="_blank">http://mailman.nginx.org/mailman/listinfo/nginx-devel</a><br>
> <br>
> <br>
> _______________________________________________<br>
> nginx-devel mailing list<br>
> <a href="mailto:nginx-devel@nginx.org" target="_blank">nginx-devel@nginx.org</a><br>
> <a href="http://mailman.nginx.org/mailman/listinfo/nginx-devel" rel="noreferrer" target="_blank">http://mailman.nginx.org/mailman/listinfo/nginx-devel</a><br>
> <br>
<br>
<br>
-- <br>
Maxim Konovalov<br>
</blockquote></div>