<div dir="ltr">How does this impact 1.20.0? Shall we wait for 1.20.1?<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Apr 22, 2021 at 6:19 AM Ruslan Ermilov <<a href="mailto:ru@nginx.com">ru@nginx.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">details:   <a href="https://hg.nginx.org/nginx/rev/f2ff291bbdac" rel="noreferrer" target="_blank">https://hg.nginx.org/nginx/rev/f2ff291bbdac</a><br>
branches:  <br>
changeset: 7830:f2ff291bbdac<br>
user:      Ruslan Ermilov <<a href="mailto:ru@nginx.com" target="_blank">ru@nginx.com</a>><br>
date:      Thu Apr 22 16:12:52 2021 +0300<br>
description:<br>
Restored zeroing of ngx_channel_t in ngx_pass_open_channel().<br>
<br>
Due to structure's alignment, some uninitialized memory contents may have<br>
been passed between processes.<br>
<br>
Zeroing was removed in 0215ec9aaa8a.<br>
<br>
Reported by Johnny Wang.<br>
<br>
diffstat:<br>
<br>
 src/os/unix/ngx_process_cycle.c |  2 ++<br>
 1 files changed, 2 insertions(+), 0 deletions(-)<br>
<br>
diffs (12 lines):<br>
<br>
diff -r 2851e4c7de03 -r f2ff291bbdac src/os/unix/ngx_process_cycle.c<br>
--- a/src/os/unix/ngx_process_cycle.c   Wed Apr 21 23:24:59 2021 +0300<br>
+++ b/src/os/unix/ngx_process_cycle.c   Thu Apr 22 16:12:52 2021 +0300<br>
@@ -398,6 +398,8 @@ ngx_pass_open_channel(ngx_cycle_t *cycle<br>
     ngx_int_t      i;<br>
     ngx_channel_t  ch;<br>
<br>
+    ngx_memzero(&ch, sizeof(ngx_channel_t));<br>
+<br>
     ch.command = NGX_CMD_OPEN_CHANNEL;<br>
     ch.pid = ngx_processes[ngx_process_slot].pid;<br>
     ch.slot = ngx_process_slot;<br>
_______________________________________________<br>
nginx-devel mailing list<br>
<a href="mailto:nginx-devel@nginx.org" target="_blank">nginx-devel@nginx.org</a><br>
<a href="http://mailman.nginx.org/mailman/listinfo/nginx-devel" rel="noreferrer" target="_blank">http://mailman.nginx.org/mailman/listinfo/nginx-devel</a><br>
</blockquote></div>