<div dir="auto">I'm just a user of nginx making a comment. Simple patch, valuable find, potentially far reaching annoyance.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, 8 Jul 2021, 7:33 pm Jérémie Drouet, <<a href="mailto:jeremie.drouet@gmail.com">jeremie.drouet@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Ok, so what should I do now? Does it mean it cannot be done?<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Jul 8, 2021 at 11:31 AM Mathew Heard <<a href="mailto:mat999@gmail.com" target="_blank" rel="noreferrer">mat999@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto">This should be a major release patch. It's breaking for everyone passing the error log.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, 8 Jul 2021, 7:17 pm Jeremie Drouet, <<a href="mailto:jeremie.drouet@gmail.com" target="_blank" rel="noreferrer">jeremie.drouet@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"># HG changeset patch<br>
# User Jeremie Drouet <<a href="mailto:jeremie.drouet@gmail.com" rel="noreferrer noreferrer" target="_blank">jeremie.drouet@gmail.com</a>><br>
# Date 1625150632 -7200<br>
# Thu Jul 01 16:43:52 2021 +0200<br>
# Node ID 7db380334d2ca671b98ab7563bab9ddee501c573<br>
# Parent e0fdd75871e40e4c57ed405cadb94235550142c9<br>
Rename referrer to referer in error log<br>
<br>
According to the developer doc from mozilla, referrer should be<br>
written with only one R and everywhere in the nginx codebase, we<br>
are using referer with only one R, so to make it consistent, I<br>
propose you to replace referrer with two R in the error log<br>
message with referer with only one R.<br>
I'm also proposing this because of the work I'm doing on vector<br>
regarding a nginx log parser in which we end up having referer<br>
and referrer when we parse logs.<br>
<br>
<a href="https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Referer" rel="noreferrer noreferrer noreferrer" target="_blank">https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Referer</a><br>
<a href="https://github.com/timberio/vector/" rel="noreferrer noreferrer noreferrer" target="_blank">https://github.com/timberio/vector/</a><br>
<br>
diff -r e0fdd75871e4 -r 7db380334d2c src/http/ngx_http_request.c<br>
--- a/src/http/ngx_http_request.c Mon Jun 28 18:01:24 2021 +0300<br>
+++ b/src/http/ngx_http_request.c Thu Jul 01 16:43:52 2021 +0200<br>
@@ -3889,7 +3889,7 @@<br>
}<br>
<br>
if (r->headers_in.referer) {<br>
- p = ngx_snprintf(buf, len, ", referrer: \"%V\"",<br>
+ p = ngx_snprintf(buf, len, ", referer: \"%V\"",<br>
&r->headers_in.referer->value);<br>
buf = p;<br>
}<br>
<br>
_______________________________________________<br>
nginx-devel mailing list<br>
<a href="mailto:nginx-devel@nginx.org" rel="noreferrer noreferrer" target="_blank">nginx-devel@nginx.org</a><br>
<a href="http://mailman.nginx.org/mailman/listinfo/nginx-devel" rel="noreferrer noreferrer noreferrer" target="_blank">http://mailman.nginx.org/mailman/listinfo/nginx-devel</a><br>
</blockquote></div>
_______________________________________________<br>
nginx-devel mailing list<br>
<a href="mailto:nginx-devel@nginx.org" target="_blank" rel="noreferrer">nginx-devel@nginx.org</a><br>
<a href="http://mailman.nginx.org/mailman/listinfo/nginx-devel" rel="noreferrer noreferrer" target="_blank">http://mailman.nginx.org/mailman/listinfo/nginx-devel</a></blockquote></div><br clear="all"><br>-- <br><div dir="ltr"><table cellspacing="0" cellpadding="0" border="0">
<tbody>
<tr>
<td style="line-height:0;vertical-align:bottom;padding-right:10px;padding-top:20px;padding-bottom:20px" width="107" valign="bottom" align="left">
<a href="https://about.me/jdrouet?promo=email_sig&utm_source=product&utm_medium=email_sig&utm_campaign=gmail_api&utm_content=thumb" style="text-decoration:none" target="_blank" rel="noreferrer">
<img src="https://thumbs.about.me/thumbnail/users/j/d/r/jdrouet_emailsig.jpg?_1460019699_02" alt="" style="margin:0px;padding:0px;display:block;border:1px solid rgb(238,238,238)" width="105" height="70">
</a>
</td>
<td style="line-height:1.1;vertical-align:bottom;padding-top:20px;padding-bottom:20px" valign="bottom" align="left">
<img src="https://about.me/t/sig?u=jdrouet" style="border:0px none;margin:0px;padding:0px;overflow:hidden" width="1" height="1">
<div style="font-size:18px;font-weight:bold;color:rgb(51,51,51);font-family:"Proxima Nova",Helvetica,Arial,sans-serif">Jérémie Drouet</div>
<a href="https://about.me/jdrouet?promo=email_sig&utm_source=product&utm_medium=email_sig&utm_campaign=gmail_api&utm_content=thumb" style="text-decoration:none;font-size:12px;color:rgb(43,130,173);font-family:"Proxima Nova",Helvetica,Arial,sans-serif" target="_blank" rel="noreferrer">about.me/jdrouet
</a>
</td>
</tr>
</tbody>
</table>
</div>
</blockquote></div>