<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
</head>
<body>
<p><span style="-webkit-font-smoothing: antialiased; box-sizing:
border-box; color: rgb(36, 36, 36); font-family: -apple-system,
BlinkMacSystemFont, "Segoe UI", "Apple Color
Emoji", "Segoe UI Emoji", "Segoe UI
Web", sans-serif; font-size: 14px; font-style: normal;
font-variant-ligatures: normal; font-variant-caps: normal;
font-weight: 400; letter-spacing: normal; orphans: 2;
text-align: start; text-indent: 0px; text-transform: none;
white-space: normal; widows: 2; word-spacing: 0px;
-webkit-text-stroke-width: 0px; background-color: rgb(255, 255,
255); text-decoration-style: initial; text-decoration-color:
initial;">Hello,</span></p>
<p><span style="-webkit-font-smoothing: antialiased; box-sizing:
border-box; color: rgb(36, 36, 36); font-family: -apple-system,
BlinkMacSystemFont, "Segoe UI", "Apple Color
Emoji", "Segoe UI Emoji", "Segoe UI
Web", sans-serif; font-size: 14px; font-style: normal;
font-variant-ligatures: normal; font-variant-caps: normal;
font-weight: 400; letter-spacing: normal; orphans: 2;
text-align: start; text-indent: 0px; text-transform: none;
white-space: normal; widows: 2; word-spacing: 0px;
-webkit-text-stroke-width: 0px; background-color: rgb(255, 255,
255); text-decoration-style: initial; text-decoration-color:
initial;">Gently ping on this patch. Any comments?</span></p>
<span style="-webkit-font-smoothing: antialiased; box-sizing:
border-box; color: rgb(36, 36, 36); font-family: -apple-system,
BlinkMacSystemFont, "Segoe UI", "Apple Color
Emoji", "Segoe UI Emoji", "Segoe UI Web",
sans-serif; font-size: 14px; font-style: normal;
font-variant-ligatures: normal; font-variant-caps: normal;
font-weight: 400; letter-spacing: normal; orphans: 2; text-align:
start; text-indent: 0px; text-transform: none; white-space:
normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width:
0px; background-color: rgb(255, 255, 255); text-decoration-style:
initial; text-decoration-color: initial;">Best,</span><br>
<span style="-webkit-font-smoothing: antialiased; box-sizing:
border-box; color: rgb(36, 36, 36); font-family: -apple-system,
BlinkMacSystemFont, "Segoe UI", "Apple Color
Emoji", "Segoe UI Emoji", "Segoe UI Web",
sans-serif; font-size: 14px; font-style: normal;
font-variant-ligatures: normal; font-variant-caps: normal;
font-weight: 400; letter-spacing: normal; orphans: 2; text-align:
start; text-indent: 0px; text-transform: none; white-space:
normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width:
0px; background-color: rgb(255, 255, 255); text-decoration-style:
initial; text-decoration-color: initial;">Andres Beltran<br>
</span>
<p><span style="-webkit-font-smoothing: antialiased; box-sizing:
border-box; color: rgb(36, 36, 36); font-family: -apple-system,
BlinkMacSystemFont, "Segoe UI", "Apple Color
Emoji", "Segoe UI Emoji", "Segoe UI
Web", sans-serif; font-size: 14px; font-style: normal;
font-variant-ligatures: normal; font-variant-caps: normal;
font-weight: 400; letter-spacing: normal; orphans: 2;
text-align: start; text-indent: 0px; text-transform: none;
white-space: normal; widows: 2; word-spacing: 0px;
-webkit-text-stroke-width: 0px; background-color: rgb(255, 255,
255); text-decoration-style: initial; text-decoration-color:
initial;">On 3/14/2022 4:42 PM, Sinan Kaya wrote:</span><br
style="-webkit-font-smoothing: antialiased; box-sizing:
border-box; color: rgb(36, 36, 36); font-family: -apple-system,
BlinkMacSystemFont, "Segoe UI", "Apple Color
Emoji", "Segoe UI Emoji", "Segoe UI
Web", sans-serif; font-size: 14px; font-style: normal;
font-variant-ligatures: normal; font-variant-caps: normal;
font-weight: 400; letter-spacing: normal; orphans: 2;
text-align: start; text-indent: 0px; text-transform: none;
white-space: normal; widows: 2; word-spacing: 0px;
-webkit-text-stroke-width: 0px; background-color: rgb(255, 255,
255); text-decoration-style: initial; text-decoration-color:
initial;">
<span style="-webkit-font-smoothing: antialiased; box-sizing:
border-box; color: rgb(36, 36, 36); font-family: -apple-system,
BlinkMacSystemFont, "Segoe UI", "Apple Color
Emoji", "Segoe UI Emoji", "Segoe UI
Web", sans-serif; font-size: 14px; font-style: normal;
font-variant-ligatures: normal; font-variant-caps: normal;
font-weight: 400; letter-spacing: normal; orphans: 2;
text-align: start; text-indent: 0px; text-transform: none;
white-space: normal; widows: 2; word-spacing: 0px;
-webkit-text-stroke-width: 0px; background-color: rgb(255, 255,
255); text-decoration-style: initial; text-decoration-color:
initial;">> Subject:<br style="-webkit-font-smoothing:
antialiased; box-sizing: border-box;">
> [PATCH] fix -Wsign-conversion warning with gcc 8.2<br
style="-webkit-font-smoothing: antialiased; box-sizing:
border-box;">
> From:<br style="-webkit-font-smoothing: antialiased;
box-sizing: border-box;">
> Sinan Kaya <a class="moz-txt-link-rfc2396E" href="mailto:okaya@kernel.org"><okaya@kernel.org></a><br
style="-webkit-font-smoothing: antialiased; box-sizing:
border-box;">
> Date:<br style="-webkit-font-smoothing: antialiased;
box-sizing: border-box;">
> 3/14/2022, 4:42 PM<br style="-webkit-font-smoothing:
antialiased; box-sizing: border-box;">
><br style="-webkit-font-smoothing: antialiased; box-sizing:
border-box;">
> To:<br style="-webkit-font-smoothing: antialiased;
box-sizing: border-box;">
> <a class="moz-txt-link-abbreviated" href="mailto:nginx-devel@nginx.org">nginx-devel@nginx.org</a><br style="-webkit-font-smoothing:
antialiased; box-sizing: border-box;">
><br style="-webkit-font-smoothing: antialiased; box-sizing:
border-box;">
><br style="-webkit-font-smoothing: antialiased; box-sizing:
border-box;">
><br style="-webkit-font-smoothing: antialiased; box-sizing:
border-box;">
> # HG changeset patch<br style="-webkit-font-smoothing:
antialiased; box-sizing: border-box;">
> # User Sinan Kaya <a class="moz-txt-link-rfc2396E" href="mailto:sinan.kaya@microsoft.com"><sinan.kaya@microsoft.com></a><br
style="-webkit-font-smoothing: antialiased; box-sizing:
border-box;">
> # Date 1647289518 14400<br style="-webkit-font-smoothing:
antialiased; box-sizing: border-box;">
> # Mon Mar 14 16:25:18 2022 -0400<br
style="-webkit-font-smoothing: antialiased; box-sizing:
border-box;">
> # Node ID f22520b612969dbfa17205129510927519370000<br
style="-webkit-font-smoothing: antialiased; box-sizing:
border-box;">
> # Parent a736a7a613ea6e182ff86fbadcb98bb0f8891c0b<br
style="-webkit-font-smoothing: antialiased; box-sizing:
border-box;">
> fix -Wsign-conversion warning with gcc 8.2<br
style="-webkit-font-smoothing: antialiased; box-sizing:
border-box;">
><br style="-webkit-font-smoothing: antialiased; box-sizing:
border-box;">
> Getting compiler warning with -Wsign-conversion.<br
style="-webkit-font-smoothing: antialiased; box-sizing:
border-box;">
><br style="-webkit-font-smoothing: antialiased; box-sizing:
border-box;">
> /usr/include/nginx/core/ngx_crc32.h:31:47: warning:
conversion to<br style="-webkit-font-smoothing: antialiased;
box-sizing: border-box;">
> 'uint32_t' {aka 'unsigned int'} from 'int' may change the
sign of the<br style="-webkit-font-smoothing: antialiased;
box-sizing: border-box;">
> result [-Wsign-conversion]<br
style="-webkit-font-smoothing: antialiased; box-sizing:
border-box;">
> 31 | crc = ngx_crc32_table_short[(crc ^ (c
>> 4)) & 0xf] ^<br style="-webkit-font-smoothing:
antialiased; box-sizing: border-box;">
> (crc >> 4);<br style="-webkit-font-smoothing:
antialiased; box-sizing: border-box;">
><br style="-webkit-font-smoothing: antialiased; box-sizing:
border-box;">
> diff -r a736a7a613ea -r f22520b61296 src/core/ngx_crc32.h<br
style="-webkit-font-smoothing: antialiased; box-sizing:
border-box;">
> --- a/src/core/ngx_crc32.h Tue Feb 08 17:35:27 2022
+0300<br style="-webkit-font-smoothing: antialiased; box-sizing:
border-box;">
> +++ b/src/core/ngx_crc32.h Mon Mar 14 16:25:18 2022
-0400<br style="-webkit-font-smoothing: antialiased; box-sizing:
border-box;">
> @@ -28,7 +28,8 @@<br style="-webkit-font-smoothing:
antialiased; box-sizing: border-box;">
> while (len--) {<br style="-webkit-font-smoothing:
antialiased; box-sizing: border-box;">
> c = *p++;<br style="-webkit-font-smoothing:
antialiased; box-sizing: border-box;">
> crc = ngx_crc32_table_short[(crc ^ (c & 0xf))
& 0xf] ^ (crc >><br style="-webkit-font-smoothing:
antialiased; box-sizing: border-box;">
> 4);<br style="-webkit-font-smoothing: antialiased;
box-sizing: border-box;">
> - crc = ngx_crc32_table_short[(crc ^ (c >> 4))
& 0xf] ^ (crc >> 4);<br style="-webkit-font-smoothing:
antialiased; box-sizing: border-box;">
> + crc = ngx_crc32_table_short[(crc ^ (u_char)(c
>> 4)) & 0xf];<br style="-webkit-font-smoothing:
antialiased; box-sizing: border-box;">
> + crc = crc ^ (crc >> 4);<br
style="-webkit-font-smoothing: antialiased; box-sizing:
border-box;">
> }<br style="-webkit-font-smoothing: antialiased;
box-sizing: border-box;">
><br style="-webkit-font-smoothing: antialiased; box-sizing:
border-box;">
> return crc ^ 0xffffffff;</span></p>
</body>
</html>